Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/257#discussion_r51169533
--- Diff: core/sql/exp/exp_conv.cpp ---
@@ -9321,6 +9321,32 @@ convDoIt(char * source,
};
break;
+// gb2312 -> utf8
+// JIRA 1720
+ case CONV_GBK_F_UTF8_V:
+ {
+ int copyLen = 0;
+ int convLen = gbkToUtf8( source, sourceLen, target, targetLen);
+ if (convLen > 0) {
--- End diff --
Should this be >=? (What happens when we convert an empy string?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
