Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/344#discussion_r54319411
  
    --- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
    @@ -200,11 +200,13 @@ short CmpDescribeSeabaseTable (
                                  NABoolean withoutDivisioning = FALSE,
                                  NABoolean noTrailingSemi = FALSE,
     
    -                             // used to add or remove column definition 
from col list.
    -                             // valid for 'createLike' mode. Used for 
'alter add/drop col'.
    +                             // used to add,rem,alter column definition 
from col list.
    +                             // valid for 'createLike' mode. 
    +                             // Used for 'alter add/drop/alter col'.
                                  char * colName = NULL,
    -                             NABoolean isAdd = FALSE,
    -                             const NAColumn * nacol = NULL);
    +                             short ada = 0, // 0,add. 1,drop. 2,alter
    --- End diff --
    
    An enum would be nice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to