Github user anoopsharma00 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/344#discussion_r54324167
--- Diff: core/sql/parser/StmtDDLAlterTableAlterColumn.cpp ---
@@ -55,16 +55,22 @@ StmtDDLAlterTableAlterColumn::getText() const
//----------------------------------------------------------------------------
// CLASS StmtDDLAlterTableAlterColumnDatatype
//----------------------------------------------------------------------------
-StmtDDLAlterTableAlterColumnDatatype::StmtDDLAlterTableAlterColumnDatatype(
- const NAString &columnName
- , NAType * natype
- , CollHeap *heap)
+StmtDDLAlterTableAlterColumnDatatype::StmtDDLAlterTableAlterColumnDatatype(
+ ElemDDLNode * pColumnToAlter
+ ,CollHeap * heap)
: StmtDDLAlterTableAlterColumn(DDL_ALTER_TABLE_ALTER_COLUMN_DATATYPE,
- columnName,
+ NAString(""),
--- End diff --
yes, you are right, it is not needed for this particular case. But we would
need it for other column based operations like renaming a column (there is
another jira for rename). So we can keep it around and use it for rename
implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
