Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/349#discussion_r54586561
  
    --- Diff: core/sql/sqlcomp/PrivMgrMD.h ---
    @@ -130,7 +149,70 @@ typedef struct {
         details += to_string((long long int) objectOwner);
       }
     
    -} ObjectReference;
    +};
    +
    +class ObjectUsage
    +{
    +  public:
    +
    +  ObjectUsage()
    +  : objectUID (0),
    +    granteeID (NA_UserIdDefault),
    +    grantorIsSystem(false),
    +    objectType (COM_UNKNOWN_OBJECT),
    +    columnReferences(NULL),
    +    originalPrivs(),
    +    updatedPrivs()
    +  {}
    +
    +  virtual ~ObjectUsage ( void )
    +  {
    +    if (columnReferences)
    +    {
    +      while(!columnReferences->empty())
    +        delete columnReferences->back(), columnReferences->pop_back();
    +      delete columnReferences;
    +    }
    +  }
    +
    +  int64_t objectUID;
    +  int32_t granteeID;
    +  bool grantorIsSystem;
    +  std::string objectName;
    +  ComObjectType objectType;
    +  std::vector<ColumnReference *> *columnReferences;
    +  PrivMgrDesc originalPrivs;
    +  PrivMgrDesc updatedPrivs;
    +
    +  ColumnReference * findColumn (int32_t columnOrdinal)
    +  {
    +    if (columnReferences == NULL)
    +      return NULL;
    +    for (int i = 0; i < columnReferences->size(); i++)
    +    {
    +      ColumnReference *pRef = (*columnReferences)[i];
    +      if (pRef->columnOrdinal == columnOrdinal)
    --- End diff --
    
    I will note this and look at it for a subsequent commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to