Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/349#discussion_r54594735
--- Diff: core/sql/sqlcomp/PrivMgrMD.h ---
@@ -110,12 +106,35 @@ typedef struct {
} ViewUsage;
-typedef struct {
+// -----------------------------------------------------------------------
+// Class definitions
+// -----------------------------------------------------------------------
+class ObjectReference
+{
+ public:
+
+ ObjectReference()
+ : objectUID(0),
+ objectOwner(NA_UserIdDefault),
+ objectType(COM_UNKNOWN_OBJECT),
+ columnReferences(NULL),
+ updatedPrivs()
+ {}
+
+ virtual ~ObjectReference ( void )
+ {
+ while(!columnReferences->empty())
+ delete columnReferences->back(), columnReferences->pop_back();
--- End diff --
Maybe I'm missing something. Isn't "delete columnReferences->back(),
columnReferences->pop_back()" equivalent to { delete columnReferences->back();
columnReferences->pop_back(); }?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
