Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/559#discussion_r68619149
  
    --- Diff: 
core/sqf/src/seatrans/tm/hbasetmlib2/src/main/java/org/trafodion/dtm/HBaseTxClient.java
 ---
    @@ -597,24 +594,25 @@ public short doCommit(long transactionId) throws 
Exception {
            return TransReturnCode.RET_OK.getShort();
        }
     
    -   public short completeRequest(long transactionId) throws Exception {
    +   public short completeRequest(long transactionId) throws IOException, 
CommitUnsuccessfulException {
          if (LOG.isDebugEnabled()) LOG.debug("Enter completeRequest, txid: " + 
transactionId);
          TransactionState ts = mapTransactionStates.get(transactionId);
     
          if(ts == null) {
               LOG.error("Returning from HBaseTxClient:completeRequest, (null 
tx) retval: " + TransReturnCode.RET_NOTX.toString() + " txid: " + 
transactionId);
               return TransReturnCode.RET_NOTX.getShort();
            }
    -
    +  
    +       boolean loopBack = false;
            try {
     
            if (LOG.isTraceEnabled()) LOG.trace("TEMP completeRequest Calling 
CompleteRequest() Txid :" + transactionId);
     
               ts.completeRequest();
    -       } catch(Exception e) {
    -          LOG.error("Returning from HBaseTxClient:completeRequest, 
ts.completeRequest: txid: " + transactionId + ", EXCEPTION: " + e);
    -       throw new Exception("Exception during completeRequest, unable to 
commit.  Exception: " + e);
    -       }
    +       } catch(InterruptedException ie) {
    +          LOG.warn("Interrupting HBaseTxClient:completeRequest but 
retrying, ts.completeRequest: txid: " + transactionId + ", EXCEPTION: ", ie);
    +          loopBack = true;
    +       } while (loopBack);
    --- End diff --
    
    Same comment as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to