Github user trinakrug commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/559#discussion_r69006058
  
    --- Diff: 
core/sqf/src/seatrans/tm/hbasetmlib2/src/main/java/org/trafodion/dtm/HBaseTxClient.java
 ---
    @@ -1033,17 +961,16 @@ public void run() {
                             Map<String, byte[]> regions = null;
                             Map<Long, TransactionState> transactionStates =
                                     new HashMap<Long, TransactionState>();
    -                        try {
    -                            regions = zookeeper.checkForRecovery();
    -                        } catch (Exception e) {
    -                            if (regions != null) { // ignore no object 
returned by zookeeper.checkForRecovery
    -                               LOG.error("An ERROR occurred while checking 
for regions to recover. " + "TM: " + tmID);
    -                               StringWriter sw = new StringWriter();
    -                               PrintWriter pw = new PrintWriter(sw);
    -                               e.printStackTrace(pw);
    -                               LOG.error(sw.toString());
    -                            }
    -                        }
    +                        boolean loopBack = false;
    +                        do {
    +                           try {
    +                               regions = zookeeper.checkForRecovery();
    --- End diff --
    
    Should there be a loopBack = false after checkForRecovery in the case where 
an exception occurred but then the operation succeeded? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to