Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/564#discussion_r68972142
  
    --- Diff: core/sql/exp/exp_datetime.cpp ---
    @@ -1908,6 +1932,11 @@ scanField(char *&src,
           // An unknown character was encountered in the string.
           //
           ExRaiseSqlError(heap, diagsArea, EXE_CONVERT_STRING_ERROR);
    +      char hexstr[256];
    +      memset(hexstr, 0 , sizeof(hexstr) );
    --- End diff --
    
     Please consider removing this line.The memset is also present in 
stringToHex.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to