Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/564#discussion_r69178912
--- Diff: core/sql/cli/Statement.cpp ---
@@ -2298,6 +2298,10 @@ RETCODE Statement::resolveNames(LateNameInfoList *
lnil,
if (retcode != ex_expr::EXPR_OK)
{
diagsArea << DgSqlCode(-EXE_CONVERT_STRING_ERROR);
+ char hexstr[MAX_OFFENDING_SOURCE_DATA_DISPLAY_LEN];
--- End diff --
Need to allow room for a trailing null. You'll have to declare one more
byte here than you pass as the second parameter to stringToHex. Alternatively,
change the stringToHex function to allow for room (for example, change the
statement "outLen = (outLen / 2)" to "outLen = (outLen / 2) - 1"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
