Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/766#discussion_r84124281
  
    --- Diff: core/sql/optimizer/opt.cpp ---
    @@ -5034,6 +5029,20 @@ void OptDefaults::initialize(RelExpr* rootExpr)
          preFetchHistograms_           = FALSE;
       }
     
    +  // Find out what the RMS security key invalidation garbage collection
    +  // interval is (this mirrors the logic in runtimestats/ssmpipc.cpp), so
    +  // we can fail-safe the histogram cache.
    +
    +  char *sct = getenv("RMS_SIK_GC_INTERVAL_SECONDS");  // in seconds
    +  if (sct)
    +    {
    +      siKeyGCinterval_ = ((Int64) str_atoi(sct, str_len(sct)));
    +      if (siKeyGCinterval_ < 10)
    +        siKeyGCinterval_ = 10;
    +    }
    +  else
    +    siKeyGCinterval_ = (Int64)24 * 60 * 60; // 24 hours
    +
    --- End diff --
    
    The sik key interval is being stored as a class member.  Could someone 
change the envvar between the time you set the variable and the time it is 
used?  Would it be better to calculate it on the fly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to