Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/766#discussion_r84124548
--- Diff: core/sql/optimizer/NATable.cpp ---
@@ -275,75 +282,28 @@ void HistogramCache::getHistograms(NATable& table)
// look up the cache and get a reference to statistics for this table
cachedHistograms = lookUp(table);
- // first thing to check is, if the table to which the histograms are
cached
- // has been updated
+ // (Possibly useless) sanity tests
+
+ // Check to see if the redefinition timestamp has changed. This seems
+ // to be always stubbed to zero today on Trafodion, so this check
+ // seems to never fail.
if (cachedHistograms && (cachedHistograms->getRedefTime() !=
redefTime))
{
deCache(&cachedHistograms);
}
--- End diff --
Good thing I didn't rip out all the redeftime stuff :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
