Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/795#discussion_r85603866
--- Diff: core/sql/optimizer/RelGrby.h ---
@@ -552,7 +560,9 @@ class GroupByAgg : public RelExpr
// ---------------------------------------------------------------------
ItemExpr * groupExprTree_;
ValueIdSet groupExpr_;
-
+
+ ItemExpr * extraGrpOrderby_;
+ ValueIdSet extraOrderExpr_;
--- End diff --
I am confused how an order expression can be stored in a ValueIdSet. Should
this be a ValueIdList instead?
The order (A,B) is different from (B,A) but both would be stored in the
same ValueIdSet.
This same question applies to change in OptPhysRelExpr.cpp. There we take a
ValueIdSet, convert it to a List and make a order requirement out of it. If
order is important maybe it should start as List. If order is not important
then we could add an arrangement requirement instead of a order requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
