Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/795#discussion_r85632431
  
    --- Diff: core/sql/optimizer/RelGrby.h ---
    @@ -552,7 +560,9 @@ class GroupByAgg : public RelExpr
       // ---------------------------------------------------------------------
       ItemExpr    * groupExprTree_;
       ValueIdSet  groupExpr_;
    -
    +  
    +  ItemExpr  * extraGrpOrderby_;
    +  ValueIdSet  extraOrderExpr_;
    --- End diff --
    
    You are right Suresh. I will change it into ValueIdList, and avoid the ugly 
conversion in the OptPhysRelExpr.cpp


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to