Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/811#discussion_r86429060
--- Diff: core/sql/ustat/hs_cli.cpp ---
@@ -5442,12 +5427,17 @@ NAString
HSSample::getTempTablePartitionInfo(NABoolean unpartitionedSample,
//
void HSSample::addTruncatedSelectList(NAString & qry)
{
+ bool first = true;
for (Lng32 i = 0; i < objDef->getNumCols(); i++)
{
- if (i)
- qry += ", ";
+ if (!ComTrafReservedColName(*objDef->getColInfo(i).colname))
--- End diff --
If possible, it would be better to check whether the column is a system
column, I assume that is the intent here? There is an undocumented option to
give the divisioning columns regular, non-reserved names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
