Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/811#discussion_r86439364
--- Diff: core/sql/ustat/hs_cli.cpp ---
@@ -5442,12 +5427,17 @@ NAString
HSSample::getTempTablePartitionInfo(NABoolean unpartitionedSample,
//
void HSSample::addTruncatedSelectList(NAString & qry)
{
+ bool first = true;
for (Lng32 i = 0; i < objDef->getNumCols(); i++)
{
- if (i)
- qry += ", ";
+ if (!ComTrafReservedColName(*objDef->getColInfo(i).colname))
--- End diff --
Yes, probably not worth the trouble, if it's difficult to implement. Sorry,
I did not look at the details of the context where this method is used. Does it
have separate logic to handle syskey, salt and divisioning columns - if
necessary. I think just adding a comment in a future checkin would be enough
for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
