Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/842#discussion_r89157897
  
    --- Diff: core/sql/optimizer/BindItemExpr.cpp ---
    @@ -6451,7 +6452,13 @@ NABoolean Like::beginEndKeysApplied(CollHeap *heap)
     
       return beginEndKeysApplied_;
     
    -} // Like::beginEndKeysApplied()
    +} // PatternMatchingFunction::beginEndKeysApplied()
    +
    +ItemExpr *Regexp::applyBeginEndKeys(BindWA *bindWA, ItemExpr *boundExpr,
    +                             CollHeap *heap)
    +{
    +  return boundExpr;
    --- End diff --
    
    This is the place where we should add a check for non-default collating 
sequence, and raise error 4392 if found.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to