Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/842#discussion_r89219091
  
    --- Diff: core/sql/optimizer/ItemExpr.cpp ---
    @@ -7922,10 +7924,46 @@ ItemExpr * InverseOrder::removeInverseOrder()
     }
     
     // -----------------------------------------------------------------------
    +// member functions for PatternMatchingFunction.
    +// -----------------------------------------------------------------------
    +PatternMatchingFunction::~PatternMatchingFunction() {}
    +
    +// -----------------------------------------------------------------------
     // member functions for Like
     // -----------------------------------------------------------------------
     Like::~Like() {}
     
    +Regexp::~Regexp() {}
    +
    +
    +ItemExpr * Regexp::copyTopNode(ItemExpr *derivedNode, CollHeap* outHeap)
    +{
    +  ItemExpr *result = NULL;
    +
    +  if (derivedNode == NULL)
    +    {
    +      switch (getArity())
    +   {
    +   case 2:
    +     result = new (outHeap) Regexp(child(0), child(1),
    --- End diff --
    
    The copyTopNode() method is not supposed to copy any children. I think the 
children should be initialized with NULL here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to