Github user DaveBirdsall commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1267#discussion_r145479903
  
    --- Diff: core/sql/exp/ExpHbaseInterface.cpp ---
    @@ -842,7 +842,9 @@ Lng32 ExpHbaseInterface_JNI::insertRow(
         transID = getTransactionIDFromContext();
       retCode_ = client_->insertRow((NAHeap *)heap_, tblName.val, hbs_,
                                     useTRex_, transID, rowID, row, timestamp, 
    -                                checkAndPut, asyncOperation, useRegionXn, 
&htc);
    +                                checkAndPut, asyncOperation, useRegionXn, 
    +                           0, // checkAndPut is false, so colIndexToCheck 
is not used
    --- End diff --
    
    How will the insertRow method distinguish between the "not used" case and a 
column index of zero? (Elsewhere I saw a comment that the column index is 
0-based.)


---

Reply via email to