Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1267#discussion_r145482847
--- Diff: core/sql/exp/ExpHbaseInterface.cpp ---
@@ -842,7 +842,9 @@ Lng32 ExpHbaseInterface_JNI::insertRow(
transID = getTransactionIDFromContext();
retCode_ = client_->insertRow((NAHeap *)heap_, tblName.val, hbs_,
useTRex_, transID, rowID, row, timestamp,
- checkAndPut, asyncOperation, useRegionXn,
&htc);
+ checkAndPut, asyncOperation, useRegionXn,
+ 0, // checkAndPut is false, so colIndexToCheck
is not used
--- End diff --
The java code in HTableClient::putRow has this line of code which will
ensure that the number passed in for colIndexToCheck is meaningless when
checkAndPut is FALSE. -1 would have been easier to read. I can make that change
later, if you agree.
if (checkAndPut && colIndex == colIndexToCheck) {
---
