Hi Shambhu,

> Hi David,
>                Perforce diff is correct. In 7 new lines:
> 3 unchanged,
> 3 addition (+include <conio.h>, +hello world, +bye world)
> and 1 replace (-hello world+include header.h)

But that line is not in valid diff syntax.  Instead of:

-hello world+include header.h

it should be:

-hello world
+include header.h

So I think Perforce has produced an incorrect diff.

> I have one more question. If a Changelist has more than one file, can i do
> review of a specific file without uploading the diff text. i.e. i tried to
> enter the changelist no. in "start tag" and full path of that file in
> "module" section, but that didn't work. It displayed the diff of all files
> instead of specific file name which mentioned into "module".

I think with Perforce, the way getDiff() currently works, it simply
retrieves all files associated with the changelist.  In theory, we
could update it so that if one of the tags is specified, we could use
that as a filter against the file entries retrieved, which might be
nicer.

Cheers,
David

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Codestriker-user mailing list
Codestriker-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/codestriker-user

Reply via email to