Great - good to hear. On Mon, Sep 1, 2008 at 3:06 PM, Shambhu Sharma <[EMAIL PROTECTED]> wrote: > Hi David, > > I applied the patch you sent, and its working fine now. > Thanks a lot. > > > Regards, > Shambhu. > > On Fri, Aug 29, 2008 at 5:22 PM, David Sitsky <[EMAIL PROTECTED]> > wrote: >> >> Hi Shambhu, >> >> There does seem to be a problem. I have added a unit test for your >> diff, and now it seems ok. Try applying my diff attached to this >> email and let me know if all is well - thanks. >> >> Cheers, >> David >> >> On Fri, Aug 29, 2008 at 5:36 PM, Shambhu Sharma <[EMAIL PROTECTED]> >> wrote: >> > Hi David, >> > >> > I realized the same diff issue with Perforce, >> > later. >> > But even if the diff is correct, its not showing for rest of files. I >> > have >> > attached the screen shot and topic text file. Topic text downloaded from >> > codestriker has correct diff format for all the files, but still its >> > showing >> > diff for only first file. >> > >> > Regards, >> > Shambhu. >> > >> > On Fri, Aug 29, 2008 at 12:50 PM, David Sitsky <[EMAIL PROTECTED]> >> > wrote: >> >> >> >> Hi Shambhu, >> >> >> >> > Hi David, >> >> > Perforce diff is correct. In 7 new lines: >> >> > 3 unchanged, >> >> > 3 addition (+include <conio.h>, +hello world, +bye world) >> >> > and 1 replace (-hello world+include header.h) >> >> >> >> But that line is not in valid diff syntax. Instead of: >> >> >> >> -hello world+include header.h >> >> >> >> it should be: >> >> >> >> -hello world >> >> +include header.h >> >> >> >> So I think Perforce has produced an incorrect diff. >> >> >> >> > I have one more question. If a Changelist has more than one file, can >> >> > i >> >> > do >> >> > review of a specific file without uploading the diff text. i.e. i >> >> > tried >> >> > to >> >> > enter the changelist no. in "start tag" and full path of that file in >> >> > "module" section, but that didn't work. It displayed the diff of all >> >> > files >> >> > instead of specific file name which mentioned into "module". >> >> >> >> I think with Perforce, the way getDiff() currently works, it simply >> >> retrieves all files associated with the changelist. In theory, we >> >> could update it so that if one of the tags is specified, we could use >> >> that as a filter against the file entries retrieved, which might be >> >> nicer. >> >> >> >> Cheers, >> >> David >> > >> > >> > >> > -- >> > If linux doesn't have a solution, then u have a wrong problem. >> > >> > Shambhu Kumar Sharma >> > Arada Systems >> > 91-98864 91913 >> > > > > > -- > If linux doesn't have a solution, then u have a wrong problem. > > Shambhu Kumar Sharma > Arada Systems > 91-98864 91913 >
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Codestriker-user mailing list Codestriker-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/codestriker-user
