Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package nodejs-electron for openSUSE:Factory
checked in at 2025-05-01 15:23:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/nodejs-electron (Old)
and /work/SRC/openSUSE:Factory/.nodejs-electron.new.30101 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "nodejs-electron"
Thu May 1 15:23:01 2025 rev:155 rq:1273737 version:35.2.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/nodejs-electron/nodejs-electron.changes
2025-04-26 22:26:03.404110837 +0200
+++
/work/SRC/openSUSE:Factory/.nodejs-electron.new.30101/nodejs-electron.changes
2025-05-01 15:23:12.458483890 +0200
@@ -1,0 +2,6 @@
+Tue Apr 29 09:33:21 UTC 2025 - Bruno Pitrus <[email protected]>
+
+- Remove spurious exports of internal functions bloating binary due to
incorrectly building libnode with -fvisibility=default
+ * add this bit to use-system-libraries-in-node.patch
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ nodejs-electron.spec ++++++
--- /var/tmp/diff_new_pack.x9V8BG/_old 2025-05-01 15:23:17.174681514 +0200
+++ /var/tmp/diff_new_pack.x9V8BG/_new 2025-05-01 15:23:17.174681514 +0200
@@ -1028,7 +1028,7 @@
%if %{with lto}
%ifarch aarch64
-export LDFLAGS="$LDFLAGS -flto=auto --param ggc-min-expand=20 --param
ggc-min-heapsize=32768 --param lto-max-streaming-parallelism=4
-Wl,--no-keep-memory -Wl,--reduce-memory-overheads"
+export LDFLAGS="$LDFLAGS -flto=auto --param ggc-min-expand=20 --param
ggc-min-heapsize=32768 --param lto-max-streaming-parallelism=3
-Wl,--no-keep-memory -Wl,--reduce-memory-overheads"
%else
# x64 is fine with the the default settings (the machines have 30GB+ ram)
export LDFLAGS="$LDFLAGS -flto=auto"
++++++ use-system-libraries-in-node.patch ++++++
--- /var/tmp/diff_new_pack.x9V8BG/_old 2025-05-01 15:23:17.774706657 +0200
+++ /var/tmp/diff_new_pack.x9V8BG/_new 2025-05-01 15:23:17.778706824 +0200
@@ -1,3 +1,6 @@
+Also remove spurious exports of internal functions bloating binary due to
incorrectly building libnode with -fvisibility=default
+Both this and the unbundle flags should be upstreamed but probably separately.
+
--- src/third_party/electron_node/node.gni.orig 2025-04-20
10:49:28.656330018 +0200
+++ src/third_party/electron_node/node.gni 2025-04-20 19:08:01.482693254
+0200
@@ -73,10 +73,12 @@ declare_args() {
@@ -13,8 +16,8 @@
}
assert(!node_enable_inspector || node_use_openssl,
---- src/third_party/electron_node/unofficial.gni.orig 2025-04-20
10:49:28.656330018 +0200
-+++ src/third_party/electron_node/unofficial.gni 2025-04-20
19:16:09.442680896 +0200
+--- src/third_party/electron_node/unofficial.gni 2025-04-24
18:36:09.022852136 +0200
++++ src/third_party/electron_node/unofficial.gni 2025-04-29
11:31:11.474026894 +0200
@@ -9,6 +9,35 @@ import("$node_v8_path/gni/v8.gni")
# The actual configurations are put inside a template in unofficial.gni to
# prevent accidental edits from contributors.
@@ -76,10 +79,13 @@
"deps/postject",
"deps/sqlite",
"deps/uvwasi",
-@@ -183,17 +208,36 @@ template("node_gn_build") {
- configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
- configs += [ "//build/config/gcc:symbol_visibility_default" ]
+@@ -179,21 +204,36 @@ template("node_gn_build") {
+ if (is_mac) {
+ frameworks = [ "CoreFoundation.framework" ]
}
+- if (is_posix) {
+- configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+- configs += [ "//build/config/gcc:symbol_visibility_default" ]
+ if (use_system_ada) {
+ libs += ["ada"]
+ } else {
@@ -89,7 +95,7 @@
+ configs += [ ":system_cares" ]
+ } else {
+ deps += [ "deps/cares" ]
-+ }
+ }
if (use_system_llhttp) {
- libs += [ "llhttp" ]
+ configs += [ ":system_llhttp" ]
@@ -116,7 +122,7 @@
if (v8_enable_i18n_support) {
deps += [ "//third_party/icu" ]
}
-@@ -222,19 +266,6 @@ template("node_gn_build") {
+@@ -222,19 +262,6 @@ template("node_gn_build") {
sources += node_inspector.node_inspector_sources +
node_inspector.node_inspector_generated_sources
}
