Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package openQA for openSUSE:Factory checked in at 2026-03-10 17:53:43 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/openQA (Old) and /work/SRC/openSUSE:Factory/.openQA.new.8177 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "openQA" Tue Mar 10 17:53:43 2026 rev:820 rq:1337836 version:5.1773068319.a9347c1b Changes: -------- --- /work/SRC/openSUSE:Factory/openQA/openQA.changes 2026-03-09 16:33:01.982428227 +0100 +++ /work/SRC/openSUSE:Factory/.openQA.new.8177/openQA.changes 2026-03-10 17:54:16.557933823 +0100 @@ -2 +2 @@ -Mon Mar 09 13:08:18 UTC 2026 - [email protected] +Mon Mar 09 15:07:31 UTC 2026 - [email protected] @@ -4 +4,2 @@ -- Update to version 5.1773056733.e071deaf: +- Update to version 5.1773068319.a9347c1b: + * docs: Link to latest passed job to ensure the download tab exists @@ -5,0 +7,3 @@ + * style: Always pass a regex match to split + * style: Use map only in block form + * style: Use grep only in block form Old: ---- openQA-5.1773056733.e071deaf.obscpio New: ---- openQA-5.1773068319.a9347c1b.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ openQA-client-test.spec ++++++ --- /var/tmp/diff_new_pack.QDJPMa/_old 2026-03-10 17:54:17.809985517 +0100 +++ /var/tmp/diff_new_pack.QDJPMa/_new 2026-03-10 17:54:17.813985682 +0100 @@ -18,7 +18,7 @@ %define short_name openQA-client Name: %{short_name}-test -Version: 5.1773056733.e071deaf +Version: 5.1773068319.a9347c1b Release: 0 Summary: Test package for %{short_name} License: GPL-2.0-or-later ++++++ openQA-devel-test.spec ++++++ --- /var/tmp/diff_new_pack.QDJPMa/_old 2026-03-10 17:54:17.853987334 +0100 +++ /var/tmp/diff_new_pack.QDJPMa/_new 2026-03-10 17:54:17.857987498 +0100 @@ -18,7 +18,7 @@ %define short_name openQA-devel Name: %{short_name}-test -Version: 5.1773056733.e071deaf +Version: 5.1773068319.a9347c1b Release: 0 Summary: Test package for %{short_name} License: GPL-2.0-or-later ++++++ openQA-test.spec ++++++ --- /var/tmp/diff_new_pack.QDJPMa/_old 2026-03-10 17:54:17.897989150 +0100 +++ /var/tmp/diff_new_pack.QDJPMa/_new 2026-03-10 17:54:17.901989315 +0100 @@ -18,7 +18,7 @@ %define short_name openQA Name: %{short_name}-test -Version: 5.1773056733.e071deaf +Version: 5.1773068319.a9347c1b Release: 0 Summary: Test package for openQA License: GPL-2.0-or-later ++++++ openQA-worker-test.spec ++++++ --- /var/tmp/diff_new_pack.QDJPMa/_old 2026-03-10 17:54:17.949991297 +0100 +++ /var/tmp/diff_new_pack.QDJPMa/_new 2026-03-10 17:54:17.953991463 +0100 @@ -18,7 +18,7 @@ %define short_name openQA-worker Name: %{short_name}-test -Version: 5.1773056733.e071deaf +Version: 5.1773068319.a9347c1b Release: 0 Summary: Test package for %{short_name} License: GPL-2.0-or-later ++++++ openQA.spec ++++++ --- /var/tmp/diff_new_pack.QDJPMa/_old 2026-03-10 17:54:17.997993279 +0100 +++ /var/tmp/diff_new_pack.QDJPMa/_new 2026-03-10 17:54:18.001993444 +0100 @@ -99,7 +99,7 @@ %define devel_requires %devel_no_selenium_requires chromedriver Name: openQA -Version: 5.1773056733.e071deaf +Version: 5.1773068319.a9347c1b Release: 0 Summary: The openQA web-frontend, scheduler and tools License: GPL-2.0-or-later ++++++ openQA-5.1773056733.e071deaf.obscpio -> openQA-5.1773068319.a9347c1b.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/docs/Installing.asciidoc new/openQA-5.1773068319.a9347c1b/docs/Installing.asciidoc --- old/openQA-5.1773056733.e071deaf/docs/Installing.asciidoc 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/docs/Installing.asciidoc 2026-03-09 15:58:39.000000000 +0100 @@ -280,7 +280,7 @@ The images are available directly from the https://openqa.opensuse.org[o3] site. Download the HDD image `opensuse-Tumbleweed-x86_64@uefi-4G-<...>.qcow2` (~3.2 GB) -from the _Assets_ in the test scenario https://openqa.opensuse.org/tests/latest?arch=x86_64&distri=openqa&flavor=dev&machine=uefi-4G&test=openqa_install%2Bpublish&version=Tumbleweed#downloads[openqa_install+publish]. +from the _Assets_ in the test scenario https://openqa.opensuse.org/tests/latest?arch=x86_64&distri=openqa&flavor=dev&machine=uefi-4G&test=openqa_install%2Bpublish&version=Tumbleweed&result=passed#downloads[openqa_install+publish]. ==== The VM diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Resource/Locks.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Resource/Locks.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Resource/Locks.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Resource/Locks.pm 2026-03-09 15:58:39.000000000 +0100 @@ -106,7 +106,7 @@ return -1 unless my $barrier = $barriers->single; my $jobschema = OpenQA::Schema->singleton->resultset('Jobs'); - my @jobs = split ',', $barrier->locked_by // ''; + my @jobs = split /,/, $barrier->locked_by // ''; if ($check_dead_job) { my @related_ids = map { scalar $_->id } $barrier->owner->parents->all, $barrier->owner->children->all; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Schema/Result/Assets.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Schema/Result/Assets.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Schema/Result/Assets.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Schema/Result/Assets.pm 2026-03-09 15:58:39.000000000 +0100 @@ -67,7 +67,7 @@ $size //= 0; opendir(my $dh, $dir) || return 0; - for my $dirContent (grep !/^\.\.?/, readdir $dh) { + for my $dirContent (grep { !/^\.\.?/ } readdir $dh) { $dirContent = "$dir/$dirContent"; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Schema/ResultSet/Assets.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Schema/ResultSet/Assets.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Schema/ResultSet/Assets.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Schema/ResultSet/Assets.pm 2026-03-09 15:58:39.000000000 +0100 @@ -23,7 +23,10 @@ # called when uploading an asset or finding one in scanning sub register ($self, $type, $name, $options = {}) { unless ($name) { log_warning 'attempt to register asset with empty name'; return undef } - unless (grep /^$type$/, TYPES) { log_warning "asset type '$type' invalid"; return undef } + unless (grep { /^$type$/ } TYPES) { + log_warning "asset type '$type' invalid"; + return undef; + } if (!$options->{missing_ok} && !locate_asset $type, $name, mustexist => 1) { log_warning "no file found for asset '$name' type '$type'"; return undef; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Schema/ResultSet/Jobs.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Schema/ResultSet/Jobs.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Schema/ResultSet/Jobs.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Schema/ResultSet/Jobs.pm 2026-03-09 15:58:39.000000000 +0100 @@ -379,7 +379,7 @@ sub _accept_comma_separated_arg_values ($args) { for my $arg (qw(state ids result modules modules_result)) { next unless my $value = $args->{$arg}; - $args->{$arg} = [split ',', $value] unless ref $value eq 'ARRAY'; + $args->{$arg} = [split /,/, $value] unless ref $value eq 'ARRAY'; } } @@ -454,8 +454,8 @@ while (my $j = $jobs_without_comments->next) { # the value we get from that @important_builds search above # could be just BUILD or VERSION-BUILD - next if grep $j->BUILD eq $_, @important_builds; - next if grep join('-', $j->VERSION, $j->BUILD) eq $_, @important_builds; + next if grep { $j->BUILD eq $_ } @important_builds; + next if grep { join('-', $j->VERSION, $j->BUILD) eq $_ } @important_builds; push @unimportant_jobs, $j->id; } # if there are only important jobs there is nothing left for us to do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Script/CloneJob.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Script/CloneJob.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Script/CloneJob.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Script/CloneJob.pm 2026-03-09 15:58:39.000000000 +0100 @@ -125,7 +125,7 @@ return undef unless ref $missing_assets eq 'ARRAY'; # most likely an old version of the web UI my @relevant_missing_assets; for my $missing_asset (@$missing_assets) { - my ($type, $name) = split '/', $missing_asset, 2; + my ($type, $name) = split qr{/}, $missing_asset, 2; push @relevant_missing_assets, $missing_asset unless _is_asset_generated_by_cloned_jobs $job, $parents, $name, $options; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Setup.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Setup.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Setup.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Setup.pm 2026-03-09 15:58:39.000000000 +0100 @@ -72,7 +72,7 @@ return; } my %hash = map { my ($k, $s, $r) = $_ =~ /$u/g; $k => {scale => $s, reference => $r // 0} } - split ',', $throttling; + split /,/, $throttling; return \%hash; } @@ -394,7 +394,7 @@ } sub prepare_settings_ui_keys ($app) { - my @link_keys = split ',', $app->config->{job_settings_ui}->{keys_to_render_as_links}; + my @link_keys = split /,/, $app->config->{job_settings_ui}->{keys_to_render_as_links}; $app->config->{settings_ui_links} = {map { $_ => 1 } @link_keys}; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Utils.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Utils.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Utils.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Utils.pm 2026-03-09 15:58:39.000000000 +0100 @@ -237,7 +237,7 @@ return '' unless defined $url_tokenized[1]; $url_tokenized[1] =~ s{\.git$}{}; $url_tokenized[1] .= '/commit/'; - my @githost = split '@', $url_tokenized[0]; + my @githost = split /@/, $url_tokenized[0]; return '' unless defined $githost[1]; return "https://$githost[1]/$url_tokenized[1]";; } @@ -682,7 +682,7 @@ # This method have its limits while checking out different branches # but emulates git-describe output without executing commands. if ($master_head && $packed_refs) { - my $latest_ref = (grep /tags/, split /\s/, $packed_refs)[-1]; + my $latest_ref = (grep { /tags/ } split /\s/, $packed_refs)[-1]; my $partial_hash = substr $master_head, 0, 8; if ($latest_ref && $partial_hash) { my $tag = (split /\//, $latest_ref)[-1]; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/API/V1/Job.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/API/V1/Job.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 2026-03-09 15:58:39.000000000 +0100 @@ -115,7 +115,7 @@ # clearer. for my $arg (qw(state ids result)) { next unless defined(my $value = $self->param($arg)); - my $values = $args{$arg} = index($value, ',') != -1 ? [split ',', $value] : $self->every_param($arg); + my $values = $args{$arg} = index($value, ',') != -1 ? [split /,/, $value] : $self->every_param($arg); if ($arg eq 'ids') { for my $id (@$values) { return $self->render(json => {error => 'ids must be integers'}, status => 400) @@ -623,7 +623,7 @@ my @allowed_cols = qw(group_id priority); for my $key (keys %$json) { return $self->render(json => {error => "Column $key can not be set"}, status => 400) - unless grep $_ eq $key, @allowed_cols; + unless grep { $_ eq $key } @allowed_cols; } # validate specified group @@ -834,7 +834,7 @@ my $auto = defined $validation->param('dup_type_auto') ? int($validation->param('dup_type_auto')) : 0; my $comment = $validation->param('comment'); - my %settings = map { split '=', $_, 2 } @{$validation->every_param('set')}; + my %settings = map { split /=/, $_, 2 } @{$validation->every_param('set')}; my @params = map { $validation->param($_) ? ($_ => 1) : () } @flags; push @params, clone => !defined $validation->param('clone') || $validation->param('clone'); push @params, prio => int($validation->param('prio')) if defined $validation->param('prio'); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/API/V1/Search.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/API/V1/Search.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/API/V1/Search.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/API/V1/Search.pm 2026-03-09 15:58:39.000000000 +0100 @@ -85,10 +85,10 @@ my $basename = $distri->basename; my $last_filename = ''; - my @lines = split "\n", $stdout; + my @lines = split /\n/, $stdout; foreach my $match (@lines) { next unless length $match; - my ($filename, $linenr, $contents) = split ':', $match, 3; + my ($filename, $linenr, $contents) = split /:/, $match, 3; # Prefix each line with a 5 digit-padded number $contents = sprintf('%5d ', $linenr) . $contents; # Merge lines occurring in the same file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/File.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/File.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/File.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/File.pm 2026-03-09 15:58:39.000000000 +0100 @@ -52,7 +52,7 @@ $path = substr $path, 0, -1; if (index($path, '/needles') != -1) { # we got something like /var/lib/openqa/share/tests/distri/needles/(subdir)/needle.json - my @elems = split '/needles', $path, 2; + my @elems = split qr{/needles}, $path, 2; if (defined $elems[1]) { $needledir .= $elems[1]; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/Main.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/Main.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/Main.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/Main.pm 2026-03-09 15:58:39.000000000 +0100 @@ -179,8 +179,8 @@ ); $self->respond_to( json => sub ($self) { - @comments = map $_->hash, @comments; - @pinned_comments = map $_->hash, @pinned_comments; + @comments = map { $_->hash } @comments; + @pinned_comments = map { $_->hash } @pinned_comments; $self->render( json => { group => $group_hash, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/Step.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/Step.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/Step.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/Step.pm 2026-03-09 15:58:39.000000000 +0100 @@ -355,7 +355,7 @@ $needle_info->{title} = $needle_info->{avg_similarity} . '%: ' . $needle_name; } for my $tag (@{$needle_info->{tags}}) { - push @$overall_list_of_tags, $tag unless grep /^$tag$/, @$overall_list_of_tags; + push @$overall_list_of_tags, $tag unless grep { /^$tag$/ } @$overall_list_of_tags; } return $needle_info; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/Test.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/Test.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Controller/Test.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Controller/Test.pm 2026-03-09 15:58:39.000000000 +0100 @@ -684,8 +684,8 @@ ); my @jobs = $jobs_rs->all; - my $failed_modules_by_job = $self->_fetch_failed_modules_by_jobs([map $_->id, @jobs]); - my ($children_by_job, $parents_by_job) = $self->_fetch_dependencies_by_jobs([map $_->id, @jobs]); + my $failed_modules_by_job = $self->_fetch_failed_modules_by_jobs([map { $_->id } @jobs]); + my ($children_by_job, $parents_by_job) = $self->_fetch_dependencies_by_jobs([map { $_->id } @jobs]); my $comment_data = $self->schema->resultset('Comments')->comment_data_for_jobs(\@jobs, {bugdetails => 1}); my (@data, @info); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Description.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Description.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Description.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Description.pm 2026-03-09 15:58:39.000000000 +0100 @@ -39,7 +39,7 @@ next unless ($rt->to->{controller}); my $filename = ucfirst($rt->to->{controller}); if ($filename =~ /_/) { - $filename = join '', map ucfirst, split /_/, $filename; + $filename = join '', map { ucfirst } split /_/, $filename; } $filename .= '.pm'; $controllers{$rt->to->{controller}} = $filename; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Plugin/Helpers.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Plugin/Helpers.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Plugin/Helpers.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Plugin/Helpers.pm 2026-03-09 15:58:39.000000000 +0100 @@ -218,7 +218,7 @@ $app->helper( build_progress_bar_title => sub ($c, $res) { my @keys = qw(passed unfinished softfailed failed skipped total); - return join "\n", map "$_: $res->{$_}", grep $res->{$_}, @keys; + return join "\n", map { "$_: $res->{$_}" } grep { $res->{$_} } @keys; }); $app->helper( @@ -452,11 +452,11 @@ } sub _every_non_empty_param ($c, $param_key) { - [map { split ',', $_ } @{$c->every_param($param_key)}] + [map { split /,/, $_ } @{$c->every_param($param_key)}] } sub _every_key_value_param ($c, $param_key) { - return {map { split('=', $_, 2) } @{$c->validation->every_param($param_key)}}; + return {map { split /=/, $_, 2 } @{$c->validation->every_param($param_key)}}; } sub _compute_overview_filtering_params ($c) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Plugin/ObsRsync.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Plugin/ObsRsync.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI/Plugin/ObsRsync.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI/Plugin/ObsRsync.pm 2026-03-09 15:58:39.000000000 +0100 @@ -512,7 +512,7 @@ die "SSH key file not found at $key" unless -s $key; # This needs to be a bit portable for CI testing my $tmp = Mojo::File::tempfile('obs-rsync-ssh-keyfile-XXXXX', TMPDIR => 1)->spew($value); - my @lines = split "\n", qx/ssh-keygen -Y sign -f "$key" -q -n "$realm" < $tmp/; + my @lines = split /\n/, qx/ssh-keygen -Y sign -f "$key" -q -n "$realm" < $tmp/; shift @lines; pop @lines; return join '', @lines; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/WebAPI.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/WebAPI.pm 2026-03-09 15:58:39.000000000 +0100 @@ -516,7 +516,7 @@ # allow configuring Cross-Origin Resource Sharing (CORS) if (my $access_control_allow_origin = $config->{global}->{access_control_allow_origin_header}) { - my %allowed_origins = map { trim($_) => 1 } split ',', $access_control_allow_origin; + my %allowed_origins = map { trim($_) => 1 } split /,/, $access_control_allow_origin; my $fallback_origin = delete $allowed_origins{'*'} ? '*' : undef; $app->hook( after_render => sub ($c, $output, $format) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1773056733.e071deaf/lib/OpenQA/Worker/Settings.pm new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Worker/Settings.pm --- old/openQA-5.1773056733.e071deaf/lib/OpenQA/Worker/Settings.pm 2026-03-09 12:45:33.000000000 +0100 +++ new/openQA-5.1773068319.a9347c1b/lib/OpenQA/Worker/Settings.pm 2026-03-09 15:58:39.000000000 +0100 @@ -30,7 +30,7 @@ my %global_settings; _read_section($cfg, 'global', \%global_settings); _read_section($cfg, $_, \%global_settings) for @{_relevant_sections($cfg, $instance_number)}; - _read_section($cfg, "class:$_", \%global_settings, 1) for split ',', $global_settings{WORKER_CLASS} // ''; + _read_section($cfg, "class:$_", \%global_settings, 1) for split /,/, $global_settings{WORKER_CLASS} // ''; # read global settings from environment variables for my $var (qw(LOG_DIR TERMINATE_AFTER_JOBS_DONE)) { @@ -140,7 +140,7 @@ } sub has_class ($self, $worker_class) { - my $c = $self->{_worker_classes} //= {map { $_ => 1 } split ',', $self->global_settings->{WORKER_CLASS} // ''}; + my $c = $self->{_worker_classes} //= {map { $_ => 1 } split /,/, $self->global_settings->{WORKER_CLASS} // ''}; return exists $c->{$worker_class}; } ++++++ openQA.obsinfo ++++++ --- /var/tmp/diff_new_pack.QDJPMa/_old 2026-03-10 17:54:37.718807495 +0100 +++ /var/tmp/diff_new_pack.QDJPMa/_new 2026-03-10 17:54:37.718807495 +0100 @@ -1,5 +1,5 @@ name: openQA -version: 5.1773056733.e071deaf -mtime: 1773056733 -commit: e071deaf70856b3cb629e753cbb7f864afbfb37d +version: 5.1773068319.a9347c1b +mtime: 1773068319 +commit: a9347c1b5ff7779798e2286164f43c4ac7363945
