Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package libstorage-ng for openSUSE:Factory
checked in at 2023-06-17 22:20:03
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libstorage-ng (Old)
and /work/SRC/openSUSE:Factory/.libstorage-ng.new.15902 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libstorage-ng"
Sat Jun 17 22:20:03 2023 rev:228 rq:1093332 version:4.5.120
Changes:
--------
--- /work/SRC/openSUSE:Factory/libstorage-ng/libstorage-ng.changes
2023-06-12 15:26:04.822920288 +0200
+++ /work/SRC/openSUSE:Factory/.libstorage-ng.new.15902/libstorage-ng.changes
2023-06-17 22:20:12.411499592 +0200
@@ -1,0 +2,16 @@
+Thu Jun 15 14:36:02 UTC 2023 - aschn...@suse.com
+
+- merge gh#openSUSE/libstorage-ng#936
+- use correct error callback when nvme-cli is missing during probing
+- 4.5.120
+
+--------------------------------------------------------------------
+Wed Jun 14 14:14:16 UTC 2023 - aschn...@suse.com
+
+- merge gh#openSUSE/libstorage-ng#935
+- added functions to convert BcacheType and CacheMode to string
+- added pool name for bcaches
+- check range in is_usable_as_partitionable()
+- 4.5.119
+
+--------------------------------------------------------------------
Old:
----
libstorage-ng-4.5.118.tar.xz
New:
----
libstorage-ng-4.5.120.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libstorage-ng.spec ++++++
--- /var/tmp/diff_new_pack.gB6FQf/_old 2023-06-17 22:20:13.695507309 +0200
+++ /var/tmp/diff_new_pack.gB6FQf/_new 2023-06-17 22:20:13.699507332 +0200
@@ -18,7 +18,7 @@
%define libname %{name}1
Name: libstorage-ng
-Version: 4.5.118
+Version: 4.5.120
Release: 0
Summary: Library for storage management
License: GPL-2.0-only
++++++ libstorage-ng-4.5.118.tar.xz -> libstorage-ng-4.5.120.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/LIBVERSION
new/libstorage-ng-4.5.120/LIBVERSION
--- old/libstorage-ng-4.5.118/LIBVERSION 2023-06-12 11:37:48.000000000
+0200
+++ new/libstorage-ng-4.5.120/LIBVERSION 2023-06-15 16:36:02.000000000
+0200
@@ -1 +1 @@
-1.88.0
+1.89.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/VERSION
new/libstorage-ng-4.5.120/VERSION
--- old/libstorage-ng-4.5.118/VERSION 2023-06-12 11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/VERSION 2023-06-15 16:36:02.000000000 +0200
@@ -1 +1 @@
-4.5.118
+4.5.120
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/storage/Devices/Bcache.cc
new/libstorage-ng-4.5.120/storage/Devices/Bcache.cc
--- old/libstorage-ng-4.5.118/storage/Devices/Bcache.cc 2023-06-12
11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/Bcache.cc 2023-06-15
16:36:02.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * Copyright (c) [2016-2019] SUSE LLC
+ * Copyright (c) [2016-2023] SUSE LLC
*
* All Rights Reserved.
*
@@ -30,6 +30,20 @@
using namespace std;
+ string
+ get_bcache_type_name(BcacheType bcache_type)
+ {
+ return toString(bcache_type);
+ }
+
+
+ string
+ get_cache_mode_name(CacheMode cache_mode)
+ {
+ return toString(cache_mode);
+ }
+
+
Bcache*
Bcache::create(Devicegraph* devicegraph, const string& name)
{
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/storage/Devices/Bcache.h
new/libstorage-ng-4.5.120/storage/Devices/Bcache.h
--- old/libstorage-ng-4.5.118/storage/Devices/Bcache.h 2023-06-12
11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/Bcache.h 2023-06-15
16:36:02.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * Copyright (c) [2016-2020] SUSE LLC
+ * Copyright (c) [2016-2023] SUSE LLC
*
* All Rights Reserved.
*
@@ -45,6 +45,14 @@
/**
+ * Convert the BcacheType bcache_type to a string.
+ *
+ * @see BcacheType
+ */
+ std::string get_bcache_type_name(BcacheType bcache_type);
+
+
+ /**
* The Cache mode attribute.
*/
enum class CacheMode {
@@ -53,6 +61,14 @@
/**
+ * Convert the CacheMode cache_mode to a string.
+ *
+ * @see CacheMode
+ */
+ std::string get_cache_mode_name(CacheMode cache_mode);
+
+
+ /**
* A <a
href="https://www.kernel.org/doc/Documentation/bcache.txt";>bcache</a> device.
*
* Bcache technology supports two kinds of bcache devices. Bcache devices
with a backing
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.118/storage/Devices/BcacheCsetImpl.h
new/libstorage-ng-4.5.120/storage/Devices/BcacheCsetImpl.h
--- old/libstorage-ng-4.5.118/storage/Devices/BcacheCsetImpl.h 2023-06-12
11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/BcacheCsetImpl.h 2023-06-15
16:36:02.000000000 +0200
@@ -45,8 +45,7 @@
{
public:
- Impl()
- : Device::Impl(), uuid() {}
+ Impl() : Device::Impl() {}
Impl(const xmlNode* node);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/storage/Devices/BcacheImpl.cc
new/libstorage-ng-4.5.120/storage/Devices/BcacheImpl.cc
--- old/libstorage-ng-4.5.118/storage/Devices/BcacheImpl.cc 2023-06-12
11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/BcacheImpl.cc 2023-06-15
16:36:02.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * Copyright (c) [2016-2020] SUSE LLC
+ * Copyright (c) [2016-2023] SUSE LLC
*
* All Rights Reserved.
*
@@ -70,6 +70,7 @@
"writethrough", "writeback", "writearound", "none"
});
+
Bcache::Impl::Impl(const string& name, BcacheType type)
: Partitionable::Impl(name), cache_mode(CacheMode::NONE),
sequential_cutoff(0), type(type), writeback_percent(0)
@@ -199,6 +200,16 @@
}
+ string
+ Bcache::Impl::pool_name() const
+ {
+ if (!is_usable_as_partitionable())
+ return "";
+
+ return "bcaches";
+ }
+
+
static bool
is_backed(Prober& prober, const string& short_name)
{
@@ -258,7 +269,7 @@
// mapping between human string of libstorage-ng and bcache sysfs sizes
- static const map<std::string, unsigned long long> size_mapping = {
+ static const map<string, unsigned long long> size_mapping = {
{ "k", KiB },
{ "M", MiB },
{ "G", GiB }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/storage/Devices/BcacheImpl.h
new/libstorage-ng-4.5.120/storage/Devices/BcacheImpl.h
--- old/libstorage-ng-4.5.118/storage/Devices/BcacheImpl.h 2023-06-12
11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/BcacheImpl.h 2023-06-15
16:36:02.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * Copyright (c) [2016-2019] SUSE LLC
+ * Copyright (c) [2016-2023] SUSE LLC
*
* All Rights Reserved.
*
@@ -96,7 +96,7 @@
BcacheType get_type() const { return type; }
- virtual string pool_name() const override { return ""; }
+ virtual string pool_name() const override;
CacheMode get_cache_mode() const { return cache_mode; }
void set_cache_mode(CacheMode mode) { cache_mode = mode; }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/storage/Devices/DasdImpl.cc
new/libstorage-ng-4.5.120/storage/Devices/DasdImpl.cc
--- old/libstorage-ng-4.5.118/storage/Devices/DasdImpl.cc 2023-06-12
11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/DasdImpl.cc 2023-06-15
16:36:02.000000000 +0200
@@ -126,6 +126,9 @@
bool
Dasd::Impl::is_usable_as_partitionable() const
{
+ if (!Partitionable::Impl::is_usable_as_partitionable())
+ return false;
+
if (type == DasdType::ECKD && (format == DasdFormat::CDL || format ==
DasdFormat::LDL))
return true;
@@ -139,6 +142,9 @@
string
Dasd::Impl::pool_name() const
{
+ if (!is_usable_as_partitionable())
+ return "";
+
if (get_type() == DasdType::ECKD)
{
if (get_format() == DasdFormat::CDL)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.118/storage/Devices/DiskImpl.cc
new/libstorage-ng-4.5.120/storage/Devices/DiskImpl.cc
--- old/libstorage-ng-4.5.118/storage/Devices/DiskImpl.cc 2023-06-12
11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/DiskImpl.cc 2023-06-15
16:36:02.000000000 +0200
@@ -124,6 +124,9 @@
bool
Disk::Impl::is_usable_as_partitionable() const
{
+ if (!Partitionable::Impl::is_usable_as_partitionable())
+ return false;
+
return zone_model != ZoneModel::HOST_MANAGED;
}
@@ -213,10 +216,18 @@
if (is_nvme())
{
- system_info.getCmdNvmeList(); // so far just for logging
- const CmdNvmeListSubsys& cmd_nvme_list_subsys =
system_info.getCmdNvmeListSubsys();
+ try
+ {
+ system_info.getCmdNvmeList(); // so far just for logging
+ const CmdNvmeListSubsys& cmd_nvme_list_subsys =
system_info.getCmdNvmeListSubsys();
- transport = cmd_nvme_list_subsys.get_transport(get_name(),
system_info);
+ transport = cmd_nvme_list_subsys.get_transport(get_name(),
system_info);
+ }
+ catch (const Exception& exception)
+ {
+ // TRANSLATORS: error message
+ prober.handle(exception, sformat(_("Probing disk %s failed"),
get_name()), UF_NVME);
+ }
}
else if (is_pmem() || is_brd())
{
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.118/storage/Devices/PartitionableImpl.h
new/libstorage-ng-4.5.120/storage/Devices/PartitionableImpl.h
--- old/libstorage-ng-4.5.118/storage/Devices/PartitionableImpl.h
2023-06-12 11:37:48.000000000 +0200
+++ new/libstorage-ng-4.5.120/storage/Devices/PartitionableImpl.h
2023-06-15 16:36:02.000000000 +0200
@@ -49,7 +49,7 @@
unsigned int get_range() const { return range; }
void set_range(unsigned int range) { Impl::range = range; }
- virtual bool is_usable_as_partitionable() const { return true; }
+ virtual bool is_usable_as_partitionable() const { return range > 1; }
PtType get_default_partition_table_type() const;
@@ -74,6 +74,9 @@
virtual string partition_name(int number) const;
+ /**
+ * Returns empty string iff no pool name applies.
+ */
virtual string pool_name() const = 0;
virtual bool equal(const Device::Impl& rhs) const override;
