Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package libstorage-ng for openSUSE:Factory
checked in at 2024-01-18 21:51:40
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libstorage-ng (Old)
and /work/SRC/openSUSE:Factory/.libstorage-ng.new.16006 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libstorage-ng"
Thu Jan 18 21:51:40 2024 rev:256 rq:1139438 version:4.5.174
Changes:
--------
--- /work/SRC/openSUSE:Factory/libstorage-ng/libstorage-ng.changes
2024-01-15 22:11:44.326404458 +0100
+++ /work/SRC/openSUSE:Factory/.libstorage-ng.new.16006/libstorage-ng.changes
2024-01-18 21:51:46.113220493 +0100
@@ -1,0 +2,9 @@
+Wed Jan 17 11:29:29 UTC 2024 - aschn...@suse.com
+
+- merge gh#openSUSE/libstorage-ng#979
+- allow to get Arch object from SystemInfo
+- make testcase more robust
+- coding style
+- 4.5.174
+
+--------------------------------------------------------------------
Old:
----
libstorage-ng-4.5.173.tar.xz
New:
----
libstorage-ng-4.5.174.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libstorage-ng.spec ++++++
--- /var/tmp/diff_new_pack.DZ7bbs/_old 2024-01-18 21:51:47.065254846 +0100
+++ /var/tmp/diff_new_pack.DZ7bbs/_new 2024-01-18 21:51:47.069254991 +0100
@@ -18,7 +18,7 @@
%define libname %{name}1
Name: libstorage-ng
-Version: 4.5.173
+Version: 4.5.174
Release: 0
Summary: Library for storage management
License: GPL-2.0-only
++++++ libstorage-ng-4.5.173.tar.xz -> libstorage-ng-4.5.174.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.173/LIBVERSION
new/libstorage-ng-4.5.174/LIBVERSION
--- old/libstorage-ng-4.5.173/LIBVERSION 2024-01-13 00:59:31.000000000
+0100
+++ new/libstorage-ng-4.5.174/LIBVERSION 2024-01-17 12:29:29.000000000
+0100
@@ -1 +1 @@
-1.98.0
+1.99.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.173/VERSION
new/libstorage-ng-4.5.174/VERSION
--- old/libstorage-ng-4.5.173/VERSION 2024-01-13 00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/VERSION 2024-01-17 12:29:29.000000000 +0100
@@ -1 +1 @@
-4.5.173
+4.5.174
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.173/bindings/storage-catches.i
new/libstorage-ng-4.5.174/bindings/storage-catches.i
--- old/libstorage-ng-4.5.173/bindings/storage-catches.i 2024-01-13
00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/bindings/storage-catches.i 2024-01-17
12:29:29.000000000 +0100
@@ -438,5 +438,6 @@
%catches(storage::DeviceNotFound, storage::DeviceHasWrongType)
storage::StrayBlkDevice::find_by_name(Devicegraph *devicegraph, const
std::string &name);
%catches(storage::DeviceNotFound, storage::DeviceHasWrongType)
storage::StrayBlkDevice::find_by_name(const Devicegraph *devicegraph, const
std::string &name);
%catches(storage::HolderAlreadyExists) storage::Subdevice::create(Devicegraph
*devicegraph, const Device *source, const Device *target);
+%catches(storage::Exception) storage::SystemInfo::get_arch();
%catches(storage::HolderAlreadyExists) storage::User::create(Devicegraph
*devicegraph, const Device *source, const Device *target);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.173/storage/Devices/Partition.cc
new/libstorage-ng-4.5.174/storage/Devices/Partition.cc
--- old/libstorage-ng-4.5.173/storage/Devices/Partition.cc 2024-01-13
00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/storage/Devices/Partition.cc 2024-01-17
12:29:29.000000000 +0100
@@ -131,7 +131,7 @@
IdNum
get_linux_partition_id(LinuxPartitionIdCategory
linux_partition_id_category, SystemInfo& system_info)
{
- return get_linux_partition_id(linux_partition_id_category,
system_info.get_impl().getArch());
+ return get_linux_partition_id(linux_partition_id_category,
system_info.get_arch());
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.173/storage/StorageImpl.cc
new/libstorage-ng-4.5.174/storage/StorageImpl.cc
--- old/libstorage-ng-4.5.173/storage/StorageImpl.cc 2024-01-13
00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/storage/StorageImpl.cc 2024-01-17
12:29:29.000000000 +0100
@@ -276,7 +276,7 @@
void
Storage::Impl::probe_helper(const ProbeCallbacks* probe_callbacks,
Devicegraph* probed, SystemInfo& system_info)
{
- arch = system_info.get_impl().getArch();
+ arch = system_info.get_arch();
Prober prober(storage, probe_callbacks, probed, system_info.get_impl());
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.173/storage/SystemInfo/SystemInfo.cc
new/libstorage-ng-4.5.174/storage/SystemInfo/SystemInfo.cc
--- old/libstorage-ng-4.5.173/storage/SystemInfo/SystemInfo.cc 2024-01-13
00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/storage/SystemInfo/SystemInfo.cc 2024-01-17
12:29:29.000000000 +0100
@@ -34,4 +34,11 @@
SystemInfo::~SystemInfo() = default;
+
+ const Arch&
+ SystemInfo::get_arch()
+ {
+ return get_impl().getArch();
+ }
+
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/libstorage-ng-4.5.173/storage/SystemInfo/SystemInfo.h
new/libstorage-ng-4.5.174/storage/SystemInfo/SystemInfo.h
--- old/libstorage-ng-4.5.173/storage/SystemInfo/SystemInfo.h 2024-01-13
00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/storage/SystemInfo/SystemInfo.h 2024-01-17
12:29:29.000000000 +0100
@@ -31,6 +31,9 @@
namespace storage
{
+ class Arch;
+
+
/**
* The SystemInfo class keeps various system information.
*
@@ -49,6 +52,13 @@
SystemInfo();
~SystemInfo();
+ /**
+ * Get an Arch object.
+ *
+ * @throw Exception
+ */
+ const Arch& get_arch();
+
public:
class Impl;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.173/storage/Utils/SystemCmd.h
new/libstorage-ng-4.5.174/storage/Utils/SystemCmd.h
--- old/libstorage-ng-4.5.173/storage/Utils/SystemCmd.h 2024-01-13
00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/storage/Utils/SystemCmd.h 2024-01-17
12:29:29.000000000 +0100
@@ -119,7 +119,7 @@
* additionally to verify if the command succeeded and if not an
* exception is thrown.
*/
- std::function<bool(int)> verify = [](int exit_code){ return
exit_code == 0; };
+ std::function<bool(int)> verify = [](int exit_code) { return
exit_code == 0; };
/**
* Environment variables to override existing environment
variables. Per
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/libstorage-ng-4.5.173/testsuite/Utils/systemcmd.cc
new/libstorage-ng-4.5.174/testsuite/Utils/systemcmd.cc
--- old/libstorage-ng-4.5.173/testsuite/Utils/systemcmd.cc 2024-01-13
00:59:31.000000000 +0100
+++ new/libstorage-ng-4.5.174/testsuite/Utils/systemcmd.cc 2024-01-17
12:29:29.000000000 +0100
@@ -293,8 +293,8 @@
// Check that no file descriptors are leaked (are closed even right after
the
// SystemCmd constructor).
- // stdin, stdout and stderr - fails with valgrind
- BOOST_CHECK_EQUAL(num_open_fds(), 3);
+ // n can be more than three, e.g. in valgrind or emacs
+ const int n = num_open_fds();
SystemCmd cmd({ LS_BIN, "-1", "/proc/self/fd/" });
@@ -303,6 +303,6 @@
// stdin, stdout, stderr and an fd resulting from the opendir in ls
BOOST_CHECK_EQUAL(cmd.stdout().size(), 4);
- // still only stdin, stdout and stderr - fails with valgrind
- BOOST_CHECK_EQUAL(num_open_fds(), 3);
+ // same number of open fds as before
+ BOOST_CHECK_EQUAL(num_open_fds(), n);
}
