arnavsharma990 commented on code in PR #21391:
URL: https://github.com/apache/nuttx/pull/21391#discussion_r4445858524


##########
fs/fat/fs_fat32.c:
##########
@@ -69,7 +69,7 @@ static int     fat_open(FAR struct file *filep, FAR const 
char *relpath,
 static int     fat_close(FAR struct file *filep);
 static ssize_t fat_read(FAR struct file *filep, FAR char *buffer,
                  size_t buflen);
-static ssize_t fat_write(FAR struct file *filep, FAR const char *buffer,
+static __attribute__((unused)) ssize_t fat_write(FAR struct file *filep, FAR 
const char *buffer,

Review Comment:
   Thanks for the suggestion! I've replaced the `unused` attributes with 
`#ifndef CONFIG_FS_FAT_READONLY` guards around the function declarations and 
definitions. This also avoids compiler compatibility issues. I've pushed the 
update in the latest commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to