arnavsharma990 commented on code in PR #21391:
URL: https://github.com/apache/nuttx/pull/21391#discussion_r4490357807
##########
fs/fat/fs_fat32.c:
##########
@@ -126,6 +136,46 @@ static int fat_stat_root(FAR struct fat_mountpt_s *fs,
static int fat_stat(struct inode *mountpt, const char *relpath,
FAR struct stat *buf);
+#ifdef CONFIG_FS_FAT_READONLY
+static int fat_sync(FAR struct file *filep)
Review Comment:
I looked into the current VFS implementation. A NULL sync callback is
ambiguous: it could mean that synchronization is unnecessary, as with
inherently read-only filesystems like ROMFS, or that the filesystem does not
implement the operation.
Returning `OK` for all NULL callbacks could hide missing implementations in
writable filesystems, so I think we should establish the intended VFS behavior
first.
For now, I'll keep the no-op `fat_sync()` to preserve existing behavior. We
can address the broader VFS issue in a separate patch, if that sounds good to
you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
