xiaoxiang781216 commented on code in PR #20996:
URL: https://github.com/apache/nuttx/pull/20996#discussion_r4440273559
##########
include/nuttx/clock.h:
##########
@@ -180,10 +180,15 @@
#define NSEC2TICK(nsec) div_const_roundup(nsec, NSEC_PER_TICK)
#define USEC2TICK(usec) div_const_roundup(usec, USEC_PER_TICK)
+#define div_roundup32(n, b) (((n) + (b) - 1) / (b))
Review Comment:
why add here
##########
include/nuttx/compiler.h:
##########
@@ -740,6 +740,12 @@
# define tz_nonsecure_call __attribute__((cmse_nonsecure_call))
# endif
+#if defined(CONFIG_DEBUG_FULLOPT) && !defined(CONFIG_ARCH_64BIT) && \
+ !defined(CONFIG_ARCH_RENESAS) && !defined(CONFIG_ARCH_XTENSA) && \
+ !defined(CONFIG_ARCH_SPARC)
+# define CONFIG_HAVE_EXPRESSION_STATEMENT 1
Review Comment:
expression statement is compiler property why check
CONFIG_DEBUG_FULLOPT/CONFIG_ARCH_xxx
##########
libs/libc/stream/lib_ultoa_invert.c:
##########
@@ -57,8 +59,27 @@ FAR char *__ultoa_invert(unsigned long long val, FAR char
*str, int base)
{
int v;
+#if defined(CONFIG_HAVE_EXPRESSION_STATEMENT)
Review Comment:
why check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
