yf13 commented on code in PR #20996: URL: https://github.com/apache/nuttx/pull/20996#discussion_r4440594493
########## include/nuttx/compiler.h: ########## @@ -740,6 +740,12 @@ # define tz_nonsecure_call __attribute__((cmse_nonsecure_call)) # endif +#if defined(CONFIG_DEBUG_FULLOPT) && !defined(CONFIG_ARCH_64BIT) && \ + !defined(CONFIG_ARCH_RENESAS) && !defined(CONFIG_ARCH_XTENSA) && \ + !defined(CONFIG_ARCH_SPARC) +# define CONFIG_HAVE_EXPRESSION_STATEMENT 1 Review Comment: The div64_const optimization doesnt work when `-O0` is used. Also it increases sizes for 64bit. The disabled archs showed size growth before in membrowse so they are disabled for now. ########## include/nuttx/clock.h: ########## @@ -180,10 +180,15 @@ #define NSEC2TICK(nsec) div_const_roundup(nsec, NSEC_PER_TICK) #define USEC2TICK(usec) div_const_roundup(usec, USEC_PER_TICK) +#define div_roundup32(n, b) (((n) + (b) - 1) / (b)) Review Comment: It is here because it is only for MSEC2TICK32 below to use. Let me know if there is better place for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
