casaroli commented on code in PR #21357:
URL: https://github.com/apache/nuttx/pull/21357#discussion_r4448851980
##########
libs/libc/machine/arm64/arch_strrchr.S:
##########
@@ -124,10 +124,10 @@ def_fn ARCH_LIBCFUN(strrchr)
addp vhas_chr1.16b, vhas_chr1.16b, vhas_chr2.16b // 256->128
addp vhas_nul1.16b, vhas_nul1.16b, vhas_nul1.16b // 128->64
addp vhas_chr1.16b, vhas_chr1.16b, vhas_chr1.16b // 128->64
- mov nul_match, vhas_nul1.2d[0]
+ mov nul_match, vhas_nul1.d[0]
lsl tmp1, tmp1, #1
mov const_m1, #~0
- mov chr_match, vhas_chr1.2d[0]
+ mov chr_match, vhas_chr1.d[0]
Review Comment:
Lines 153, 154 and 161 of this file still use `.2d[0]`. clang 22 still
rejects arch_strrchr.S with "invalid operand for instruction" at these three
lines.
Fix: change them to `vend1.d[0]`, `vhas_chr1.d[0]` and `vhas_nul1.d[0]` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
