W-M-R commented on code in PR #21357:
URL: https://github.com/apache/nuttx/pull/21357#discussion_r4480395740
##########
libs/libc/machine/arm64/arch_strrchr.S:
##########
@@ -124,10 +124,10 @@ def_fn ARCH_LIBCFUN(strrchr)
addp vhas_chr1.16b, vhas_chr1.16b, vhas_chr2.16b // 256->128
addp vhas_nul1.16b, vhas_nul1.16b, vhas_nul1.16b // 128->64
addp vhas_chr1.16b, vhas_chr1.16b, vhas_chr1.16b // 128->64
- mov nul_match, vhas_nul1.2d[0]
+ mov nul_match, vhas_nul1.d[0]
lsl tmp1, tmp1, #1
mov const_m1, #~0
- mov chr_match, vhas_chr1.2d[0]
+ mov chr_match, vhas_chr1.d[0]
Review Comment:
Good catch — fixed. arch_strrchr.S still had .2d[0] in the loop and tail
paths (lines 153/154/161); all of them are .d[0] now, so the whole file
assembles with clang 22. Amended into the same commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
