casaroli commented on code in PR #21510: URL: https://github.com/apache/nuttx/pull/21510#discussion_r4501771990
########## arch/tricore/src/common/ToolchainTasking.defs: ########## @@ -165,3 +165,13 @@ CXXELFFLAGS = $(CXXFLAGS) -fvisibility=hidden LDELFFLAGS = -r -e _start LDELFFLAGS += -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)elf$(DELIM)gnu-elf.ld) + +# The astc assembler has no C preprocessor and .asm files need explicit preprocessing with ctc -E. + +define ASSEMBLE + $(ECHO_BEGIN)"AS: $1 " + $(Q) ctc -E $(AFLAGS) $1 -o $2.pp.asm + $(Q) $(CC) -c $(AFLAGS) $2.pp.asm -o $2 + $(Q) rm -f $2.pp.asm Review Comment: The new ASSEMBLE uses `rm -f` and drops the per-file `$($(strip $1)_AFLAGS)` of the default ASSEMBLE in tools/Config.mk. Fix: use `$(call DELFILE, $2.pp.asm)` and pass `$($(strip $1)_AFLAGS)` to both commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
