ssekar15 commented on code in PR #21510:
URL: https://github.com/apache/nuttx/pull/21510#discussion_r4492032559


##########
arch/tricore/src/cmake/tasking.cmake:
##########
@@ -51,6 +51,13 @@ set(CMAKE_CXX_COMPILE_OBJECT
     "<CMAKE_CXX_COMPILER> <DEFINES> <INCLUDES> <FLAGS> --create <SOURCE> -o 
<OBJECT>"
 )
 
+# The astc assembler has no C preprocessor and .asm files need explicit
+# preprocessing with ctc -E.
+
+set(CMAKE_ASM_COMPILE_OBJECT

Review Comment:
   this part is here
   
   
https://github.com/apache/nuttx/commit/d42669c805bf70f27998245b7a12920f95880012#diff-62b8ccb716fcc4c072da138049123478c3bff92308c22384152389fc28542f5fR81



##########
arch/tricore/src/common/ToolchainTasking.defs:
##########
@@ -165,3 +165,13 @@ CXXELFFLAGS = $(CXXFLAGS) -fvisibility=hidden
 
 LDELFFLAGS = -r -e _start
 LDELFFLAGS += -T $(call 
CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)elf$(DELIM)gnu-elf.ld)
+
+# The astc assembler has no C preprocessor and .asm files need explicit 
preprocessing with ctc -E.

Review Comment:
   do you mean this changes? check here
   
   
https://github.com/apache/nuttx/commit/d42669c805bf70f27998245b7a12920f95880012#diff-1c370c487a863b9b6a62a181e9816f1f2a5a8799e93392efba09818b972fee3aR112



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to