arnavsharma990 commented on PR #21391: URL: https://github.com/apache/nuttx/pull/21391#issuecomment-6677010715
Hey @casaroli, thanks for the review! I've addressed the review comments: - `fat_mount()` now passes `false` when `CONFIG_FS_FAT_READONLY` is set. - `sync`, `unlink`, `mkdir`, `rmdir`, and `rename` now use small stubs returning `OK` or `-EROFS` instead of `NULL`. - `write` and `truncate` remain `NULL`. - The commit trailer now uses `Assisted-by` above `Signed-off-by`. - The branch has been rebased onto the latest upstream `master`. I also attempted to run `sim:nsh` locally, but the build is currently blocked by a pre-existing issue in `apps/nshlib`, unrelated to this change: ```text nsh_fscmds.c:2678:27: error: call to undeclared function 'lib_get_pathbuffer' nsh_fscmds.c:2678:21: error: incompatible integer to pointer conversion nsh_fscmds.c:2682:11: error: call to undeclared function 'lib_put_pathbuffer' ``` The FAT-specific code compiles cleanly with both `CONFIG_FS_FAT_READONLY=y` and `CONFIG_FS_FAT_READONLY=n`. I haven't been able to complete the full runtime, image-hash, and size comparison tests because of the build issue. I'll update the PR description with those results once I can get the test environment working. Thanks again for the detailed feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
