xiaoxiang781216 commented on code in PR #21342:
URL: https://github.com/apache/nuttx/pull/21342#discussion_r4509929765
##########
sched/Kconfig:
##########
@@ -306,6 +306,46 @@ config SPINLOCK_INLINE
this option to emit callable non-inline versions and reduce
header-inline code growth.
+config SPINLOCK_WFESEV_DEFAULT
Review Comment:
why not remove SPINLOCK_WFESEV_DEFAULT and default to SPINLOCK_WFESEV in SMP?
##########
include/nuttx/spinlock.h:
##########
@@ -163,12 +163,12 @@ void spin_lock_notrace(FAR volatile spinlock_t *lock)
int32_t ticket = atomic_add_relaxed(&lock->next, 1);
while (atomic_read_acquire(&lock->owner) != ticket)
{
- UP_WFE();
+ SPINLOCK_WAIT();
Review Comment:
merge to the previos patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
