Fix-Point commented on code in PR #21342:
URL: https://github.com/apache/nuttx/pull/21342#discussion_r4450248983
##########
include/nuttx/spinlock.h:
##########
@@ -849,16 +915,22 @@ void spin_unlock_irqrestore_nopreempt(FAR volatile
spinlock_t *lock,
static inline_function
bool rspin_unlock(FAR rspinlock_t *lock)
{
- DEBUGASSERT(lock->owner == this_cpu() + 1);
- DEBUGASSERT(lock->count >= 1);
+ bool ret = false;
+ uint32_t val = lock->local_val;
Review Comment:
Done.
##########
include/nuttx/spinlock.h:
##########
@@ -641,7 +707,7 @@ static inline_function bool rspin_trylock(FAR rspinlock_t
*lock)
# define rspin_trylock_irqsave(l, f) \
({ \
(void)(l); \
- (f) = up_irq_save(); \
+ (f) = irq_save(); \
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
