d-smirnov commented on pull request #7564: URL: https://github.com/apache/tvm/pull/7564#issuecomment-789163786
The constants removed by this PR are actually from graph runtime module. The metadata constants are kept intact. The usage of custom ConstUpdater (in its current implementation) seems unrealistic to me due to the updater called before the metadata and graph runtime modules are created. Metadata module gets all the local consts and the consts fetched via ConstUpdater as one map. Then this map of all constants is copied to graph runtime module ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
