mbaret commented on pull request #7564: URL: https://github.com/apache/tvm/pull/7564#issuecomment-793656133
> > I doubt that what was implemented in Ethos-N is applicable to ACL (ACL relies on JSON codegen and Ethos-N uses C). Could you elaborate you proposal? > > I think this is not related to what codegen you are using? Based on the functionality of this PR, what you need is getting rid of some constatnts in the metadata module. Then it should be fine to put this logic to the ACL specific constant updater. @mbaret could you comment whether this proposal would work? Apologies @comaniac that I missed this earlier. We did explore using the same fix as for Ethos-N (giving a 'null' ConstantUpdater), but this doesn't work for ACL as ACL does load the constants from MetadataModule. Ethos-N just directly serializes the constants into the binary module so it doesn't care if they're missing in the MetadataModule. This problem seems quite fundamental to me and shouldn't just affect ACL, but any BYOC target that tries to make use of MetadataModule. > I think this is just a work around. One way I can think of is that we can make graph runtime similar to some other runtimes. Therefore, it is able to query the needed parameters. I had a local draft commit to do this some time ago but I could not find it now. Given this is a user-facing issue (https://discuss.tvm.apache.org/t/model-graph-size-doubling-after-partitioning-for-arm-compute-library/9131) and we're very interested in getting a fix in soon, could you elaborate on your alternative proposal @zhiics? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
