areusch commented on a change in pull request #7813:
URL: https://github.com/apache/tvm/pull/7813#discussion_r611807263
##########
File path: python/tvm/micro/contrib/zephyr.py
##########
@@ -108,7 +108,18 @@ def __init__(
f"project_dir supplied to ZephyrCompiler does not exist:
{project_dir}"
)
+ if "qemu" in board:
Review comment:
your diff looks right to me. I think this is one of those cases where
there is not much CPU time to be saved, and in particular since this is Python,
the `self._is_qemu` lookup could cost more time than the substring check. in
these cases, I just favor the easiest code to read/debug, rather than adding
e.g. `if self._is_qemu and "-qemu" in board` (you would the have to explain the
self._is_qemu--is this intending to capture some other criteria, which may
shift over time to be more than just `"qemu" in board`?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
