gromero commented on a change in pull request #7813:
URL: https://github.com/apache/tvm/pull/7813#discussion_r611943142
##########
File path: python/tvm/micro/contrib/zephyr.py
##########
@@ -108,7 +108,18 @@ def __init__(
f"project_dir supplied to ZephyrCompiler does not exist:
{project_dir}"
)
+ if "qemu" in board:
Review comment:
Over time I think that code will be updated to take care of FVP
emulation too (about to be added to Zephyr, for Cortex M-55 + Ethos U-55, i.e.
for MPS3 boards which are not supported by QEMU).
That said, I was actually not thinking of saving CPU cycles (I don't think
there is a difference in performance between the two forms), nor about adding
FVP support in the future, rather I just think that the first form is better to
read/debug because it makes explicit that the trimming off applies only for a
specific case where the suffix is present in the board name :) In the second
form that dependency is "weak" and one maybe need to go back to the first `if`
to realize that the second `if` will never be taken if the first is not taken.
Anyway, since the result is the same, I'm sending a new version with the change
suggested. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
