masahi commented on a change in pull request #7833:
URL: https://github.com/apache/tvm/pull/7833#discussion_r612758375
##########
File path: src/runtime/vulkan/vulkan_common.h
##########
@@ -35,6 +35,10 @@ namespace tvm {
namespace runtime {
namespace vulkan {
+#define kMaxPushConstantsBytes 128
+
+enum ShaderMetaDataKind { kUSE_UBO = 0 };
Review comment:
Yes I went with the former in the latest commit, if we use enum class I
need `static_cast` in `1 << ShaderMetaDataFlagMask::kUseUBO`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
