tqchen commented on a change in pull request #7833:
URL: https://github.com/apache/tvm/pull/7833#discussion_r612759240
##########
File path: src/runtime/vulkan/vulkan_common.h
##########
@@ -35,6 +35,10 @@ namespace tvm {
namespace runtime {
namespace vulkan {
+#define kMaxPushConstantsBytes 128
+
+enum ShaderMetaDataKind { kUSE_UBO = 0 };
Review comment:
given this is a mask(instead of the shift number). We can directly
define `kUseUBO=1` so you don't have to do left shift here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
