akmaru commented on a change in pull request #8131:
URL: https://github.com/apache/tvm/pull/8131#discussion_r639217027
##########
File path: src/runtime/contrib/tensorrt/tensorrt_ops.cc
##########
@@ -1057,7 +1057,7 @@ class ReshapeOpConverter : public TensorRTOpConverter {
class PadOpConverter : public TensorRTOpConverter {
public:
- PadOpConverter() : TensorRTOpConverter({kTensor}) {}
+ PadOpConverter() : TensorRTOpConverter({kTensor, kWeight}) {}
Review comment:
Added `pad_value` input into PadOpConverter.
##########
File path: python/tvm/relay/op/contrib/tensorrt.py
##########
@@ -723,8 +723,12 @@ def pad_annotate_fn(expr): # pylint:
disable=unused-variable
if attrs.pad_mode != "constant":
logger.info("nn.pad: pad mode is %s but must be constant.",
attrs.pad_mode)
return False
- if float(attrs.pad_value) != 0.0:
- logger.info("nn.pad: pad value is %f but must be 0.0.",
float(attrs.pad_value))
+ if (
+ isinstance(args[1], relay.Constant)
Review comment:
Certainly, that makes sense. Fixed to it so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
