fixstars-fujinami commented on a change in pull request #8131:
URL: https://github.com/apache/tvm/pull/8131#discussion_r639435555
##########
File path: python/tvm/relay/op/contrib/tensorrt.py
##########
@@ -723,8 +723,9 @@ def pad_annotate_fn(expr): # pylint:
disable=unused-variable
if attrs.pad_mode != "constant":
logger.info("nn.pad: pad mode is %s but must be constant.",
attrs.pad_mode)
return False
- if float(attrs.pad_value) != 0.0:
- logger.info("nn.pad: pad value is %f but must be 0.0.",
float(attrs.pad_value))
+ assert isinstance(args[1], relay.Constant)
+ if len(args[1].checked_type.shape) == 0 and args[1].data.numpy().item() !=
0.0:
Review comment:
I think pad_mode="constant" just means padding by pad_value, not type of
pad_value is relay.Constant.
nn.pad allows Expr for pad_value.
https://github.com/apache/tvm/blob/03c8a6f4612a91cdbb668482309de33c19ec5949/python/tvm/relay/op/nn/nn.py#L1657-L1658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
