areusch commented on pull request #8382: URL: https://github.com/apache/tvm/pull/8382#issuecomment-872352229
thanks @mikepapadim this looks like a great addition! one question on the approach: typically in order to get accurate e.g. pylint results, you need to ensure you have exactly the version of pylint, astroid, etc. as are installed in the CI. we don't currently have a programmatic way to do that outside of the `ci-lint` docker container. i made a script `docker/lint.sh` which invokes these commands in `ci-lint`--the problem with this one is that due to a limitation of the docker container mounts (see #6344), this doesn't work with git-subtree. it would be great if we could somehow introduce the docker container to this approach to make it foolproof. otherwise, it might weaken the pre-commit output if it's inaccurate. what are your thoughts? we don't have a good way to capture the python deps used in CI right now (there are some efforts underway, but it'll be a while); however, you could probably get what you need from `docker/bash.sh ci_lint pip3 freeze` if we wanted to go that approach. another approach is to push on #6344 again and try to fix the rust build issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
