mikepapadim commented on a change in pull request #8382: URL: https://github.com/apache/tvm/pull/8382#discussion_r662839717
########## File path: .pre-commit-config.yaml ########## @@ -0,0 +1,40 @@ +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v2.5.0 + hooks: + - id: check-added-large-files + - id: check-merge-conflict + - id: check-yaml + - id: end-of-file-fixer + - repo: local + hooks: + - id: run-file-types + name: Checking File Types... + entry: python3 tests/lint/check_file_type.py + language: system + always_run: true + pass_filenames: false + - id: run-headers-check + name: Checking ASF License Headers... + entry: tests/lint/check_asf_header.sh --local + language: system + always_run: true + pass_filenames: false + - id: run-black Review comment: Indeed, this can work without getting involved with the docker images. In my case, I got the from `pip freeze` the versions that docker uses and install them locally to have the same environment. I agree, I am going to update the config file with pre-canned versions matching the lint environment(https://github.com/apache/tvm/blob/ab01abc22460c6d8dcd6ed75e77b7224364014d8/docker/Dockerfile.ci_lint#L32). I think the goal of having such hook available is to reduce the fails in 1) Sanity checks stages and 2) the builds MacOs and Windows builds that are running the minimal unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
