masahi commented on a change in pull request #8466:
URL: https://github.com/apache/tvm/pull/8466#discussion_r671689944
##########
File path: src/runtime/thread_storage_scope.h
##########
@@ -96,6 +98,8 @@ struct StorageScope {
return "global" + tag;
case StorageRank::kShared:
return "shared" + tag;
+ case StorageRank::kDynShared:
Review comment:
I changed dynamic shared memory to be a tagged memory for `kShared`, but
I had to add a check `e->scope.tag != ".dyn"` in a few places in
`lower_device_storage_access_info.cc` and `storage_rewrite.cc` to workaround
error/segfault.
##########
File path: include/tvm/tir/function.h
##########
@@ -240,7 +240,7 @@ namespace attr {
*
* Call(f,
* [arg1, arg2, ..., arg_n,
- * work_size_1, work_size_2, ... work_size_m])
+ * work_size_1, work_size_2, ... work_size_m, dyn_shmem_size])
Review comment:
done
##########
File path: src/runtime/thread_storage_scope.h
##########
@@ -223,6 +232,7 @@ class ThreadAxisConfig {
w.work_size[arg_index_map_[i]] = size;
}
}
+ w.dyn_shmem_size = static_cast<size_t>(x.values[base_ +
arg_index_map_.size()].v_int64);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
