tqchen commented on a change in pull request #8466:
URL: https://github.com/apache/tvm/pull/8466#discussion_r672230286
##########
File path: src/runtime/file_utils.cc
##########
@@ -64,12 +66,14 @@ void FunctionInfo::Save(dmlc::Stream* writer) const {
writer->Write(name);
writer->Write(arg_types);
writer->Write(thread_axis_tags);
+ writer->Write(use_dyn_shared_memory);
}
bool FunctionInfo::Load(dmlc::Stream* reader) {
if (!reader->Read(&name)) return false;
if (!reader->Read(&arg_types)) return false;
if (!reader->Read(&thread_axis_tags)) return false;
+ if (!reader->Read(&use_dyn_shared_memory)) return false;
Review comment:
I think. let us think about another way to do backward compact then.
Since binary backward compatibility is more important to us here.
Here is one solution that also helps future backward compatibility.
Let us rename `thread_axis_tags => launch_param_tags`, and use
`dyn_shared_memory` as a tag for the launching parameter of dynamic shared
memory. We can then change the `ThreadAxisConfig => LaunchParamConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
