masahi commented on a change in pull request #8466:
URL: https://github.com/apache/tvm/pull/8466#discussion_r673059490
##########
File path: src/runtime/file_utils.cc
##########
@@ -64,12 +66,14 @@ void FunctionInfo::Save(dmlc::Stream* writer) const {
writer->Write(name);
writer->Write(arg_types);
writer->Write(thread_axis_tags);
+ writer->Write(use_dyn_shared_memory);
}
bool FunctionInfo::Load(dmlc::Stream* reader) {
if (!reader->Read(&name)) return false;
if (!reader->Read(&arg_types)) return false;
if (!reader->Read(&thread_axis_tags)) return false;
+ if (!reader->Read(&use_dyn_shared_memory)) return false;
Review comment:
If we do the rename `thread_axis_tags => launch_param_tags`, the JSON
reader would break backward compat at
`helper.DeclareField("launch_param_tags", &launch_param_tags);` .
Or shall we do the rename but keep the old attribute name for JSON
reader/writer? e.g.
`helper.DeclareField("thread_axis_tags", &launch_param_tags);`.
Or shall we have both new and old attribute names as optional field, e.g.
```
helper.DeclareOptionalField("launch_param_tags", &launch_param_tags);
helper.DeclareOptionalField("thread_axis_tags", &launch_param_tags); // for
backward compatibility
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
