gromero commented on PR #12189: URL: https://github.com/apache/tvm/pull/12189#issuecomment-1198633247
@leandron @guberti @mehrdadh The major issue here I see is that I have reviewed the change once, then two additional commits where added overnight (due to timezone differences) to the PR after the approvals and even one of them (https://github.com/apache/tvm/pull/12189/commits/d8472189dbca6ece5687cb299daa47bf5bb57975) touched a more generic micro code. Then no PR title or body message were updated to reflect the changes. Ideally a new PR should be created to accommodate the two additional commits in this case, with another round of reviews. Encouraging that kind of review workflow in the community is bad practice in my view and committers should guard against it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
